Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template docs incorrect #2204

Open
cristiano-belloni opened this issue Nov 12, 2022 · 0 comments
Open

Template docs incorrect #2204

cristiano-belloni opened this issue Nov 12, 2022 · 0 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@cristiano-belloni
Copy link
Contributor

cristiano-belloni commented Nov 12, 2022

In https://github.com/jpmorganchase/modular/blob/caf75ab0f9638f6e13a34eecc66907391cdf0484/docs/concepts/templates.md

The strings PackageName__ and ComponentName__ present in any of the target files will be overwritten, respectively, by the target package name as-is and the target package name converted to PascalCase (the latter is useful for source code template files where, for example, a React component is created).

This is not true; currently we do that only for ts|tsx|js|jsx|json|md|txt files:

if (/\.(ts|tsx|js|jsx|json|md|txt)$/i.test(packageFilePath)) {

@cristiano-belloni cristiano-belloni added bug Something isn't working documentation Improvements or additions to documentation labels Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant