Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

defineCell method of column definitions should support idiomatic React #7

Open
jpollard-cs opened this issue Dec 13, 2016 · 0 comments
Open

defineCell method of column definitions should support idiomatic React #7

jpollard-cs opened this issue Dec 13, 2016 · 0 comments

Comments

@jpollard-cs
Copy link
Owner

Arguments passed to the defineCell method should be passed as props so that the caller can provide a React component (maybe rename defineCell to cellRenderer). Make sure to add tests with both pure functional components and standard class-based components.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jpollard-cs