Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected reserved word #138

Open
cajoy opened this issue Aug 10, 2015 · 7 comments
Open

Unexpected reserved word #138

cajoy opened this issue Aug 10, 2015 · 7 comments

Comments

@cajoy
Copy link

cajoy commented Aug 10, 2015

I use iojs with ES6 enabled for my project.

When I use fixmyjs, I ma getting "Unexpected reserved word"

With flag --legacy everything is fine. But seems like legacy doesn't fix double quotes issue.

Alex

@warpech
Copy link

warpech commented Oct 30, 2015

Same here

@doktordirk
Copy link

same here

@zxwandrew
Copy link

running into same issue

@ChristianUlbrich
Copy link

The actual problem seems to be, that fixmyjs is using esprima ^1.2.2, that does not support ES6. Newer versions of esprima support it, so maybe a version bump to version 2 of esprima might fix this (although I bet, that they have breaking changes...). I might give it a try and submit a PR, when it is working...

@ChristianUlbrich
Copy link

FWIW: The v2.0 branch does indeed use recast and has no problems at all with ES6 code. You can give it a try; it is not on NPM though. If only the documentation would have said something about the changed semantics for specifying options...

@mgilson-argo
Copy link

It looks like esprima is now at version 4.0 on NPM. Does that mean that this issue can be revisited?

@goatslacker
Copy link
Member

Published 2.0.0 to npm. We should probably switch out the parser to something that has better ES-next support like babel's or one of acorn's forks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants