-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove compressible for db 2.0 #126
Labels
Comments
Heh, guess it kinda makes sense. That being said I think we'll just end up having like Maybe it's better to do more sniffing for text / text-related encodings in the data itself. I dunno. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Since we defined the 1.0 of the mime-db it has worked well, expect for one of the properties:
compressible
. This property cannot be derived from the upstream data and instead rules must live in this repo to populate the value. By itself, this is not too bad, but it adds additional complexity to the module as well as inflates the size of the database for something many may not even use.I'm thinking that a 2.0 version should drop this property from the database format and all related rules from this module.
The compressible data and ruleset would live on still, under the npm module
compressible
. Instead of delegating to this module for compressible data, it would instead be the store of all the rules (and would not even need to depend on this module).I'm opening this up for thoughts on this proposal, especially for those who are dependent on the database format. I'm not planning to make any changes for quite some time. Perhaps in a few months at the earliest, so there is plenty of time for feedback to fall here, if any.
The text was updated successfully, but these errors were encountered: