Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing camera resolution should invalidate calibration #124

Open
funnbot opened this issue Jan 12, 2023 · 3 comments
Open

Changing camera resolution should invalidate calibration #124

funnbot opened this issue Jan 12, 2023 · 3 comments

Comments

@funnbot
Copy link
Contributor

funnbot commented Jan 12, 2023

The camera calibration should store the resolution it was calibrated at, and if changed in the UI, should invalidate the calibration.
Calibrations could potentially be saved as well, Allowing for an array per camera that is identified by its resolution.

Are there other values that should invalidate the calibration?

@ju1ce
Copy link
Owner

ju1ce commented Jan 12, 2023

When changing resolution, it should be possible to calculate new calibration values, as only the ratios change. Automatically calculating this could be a good improvement to usability. Other settings shouldnt invalidate the calibration.

As for the calibration itself, it should be possible to automatically detect the quality of calibration and warn the user/reject the calibration in case it is not good enough. Personally, i couldnt find apropriate metrics to do this reliably: the reprojection error is not enough in some cases.

Other stuff that could be included:

  • Calculating camera trajectory to ensure a variety of views
  • Checking whether the grid is in aproximately correct position
  • Checking calibration confidence values

@funnbot
Copy link
Contributor Author

funnbot commented Jan 12, 2023

Maybe this isn't a concern, but could changing the resolution cause the image to be cropped?

@funnbot
Copy link
Contributor Author

funnbot commented Jan 12, 2023

some SO questions on camera calibration correctness
https://stackoverflow.com/questions/18052337/how-to-verify-that-the-camera-calibration-is-correct-or-how-to-estimate-the-er
https://stackoverflow.com/questions/12794876/how-to-verify-the-correctness-of-calibration-of-a-webcam

Apparently reprojection error is the best available, besides some visual inspection, very difficult to tell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants