🎆 Optimize project thumbnail/banner and fallback correctly (#1316)

jupyter-book · Jun 14, 2024 · 6326cf5 · 6326cf5
1 parent a8a745b
commit 6326cf5
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 4 deletions.
diff --git a/.changeset/chilly-flies-appear.md b/.changeset/chilly-flies-appear.md
@@ -0,0 +1,5 @@
+---
+'myst-cli': patch
+---
+
+Optimize project thumbnail/banner and fallback correctly
diff --git a/packages/myst-cli/src/build/site/manifest.ts b/packages/myst-cli/src/build/site/manifest.ts
@@ -178,23 +178,30 @@ export async function localToManifestProject(
     path.join(projectPath, 'myst.yml'),
     projFrontmatter,
     session.publicPath(),
-    { altOutputFolder: '/' },
+    { altOutputFolder: '/', webp: true },
   );
   const thumbnail = await transformThumbnail(
     session,
     null,
     path.join(projectPath, 'myst.yml'),
     projFrontmatter,
     session.publicPath(),
-    { altOutputFolder: '/' },
+    { altOutputFolder: '/', webp: true },
   );
   return {
     ...projFrontmatter,
     // TODO: a null in the project frontmatter should not fall back to index page
     thumbnail: thumbnail?.url || projectFileInfo.thumbnail,
-    thumbnailOptimized: thumbnail?.urlOptimized || projectFileInfo.thumbnailOptimized || undefined,
+    thumbnailOptimized:
+      thumbnail?.urlOptimized ||
+      // Do not fall back to optimized page thumbnail if unoptimized project thumbnail exists
+      (thumbnail?.url ? undefined : projectFileInfo.thumbnailOptimized) ||
+      undefined,
     banner: banner?.url || projectFileInfo.banner,
-    bannerOptimized: banner?.urlOptimized || projectFileInfo.bannerOptimized || undefined,
+    bannerOptimized:
+      banner?.urlOptimized ||
+      (banner?.url ? undefined : projectFileInfo.bannerOptimized) ||
+      undefined,
     exports,
     downloads,
     bibliography: projFrontmatter.bibliography || [],