Skip to content

Commit

Permalink
🏷️ Do not report available updates for whitelabelled applications (#1636
Browse files Browse the repository at this point in the history
)

Co-authored-by: Rowan Cockett <rowanc1@gmail.com>
  • Loading branch information
agoose77 and rowanc1 authored Nov 13, 2024
1 parent d8566d4 commit 6f23a6e
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/silly-comics-melt.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"myst-cli": patch
---

Do not report version updates for whitelabelled binaries
9 changes: 8 additions & 1 deletion packages/myst-cli/src/session/session.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import type { RootState } from '../store/reducers.js';
import { rootReducer } from '../store/reducers.js';
import version from '../version.js';
import type { ISession } from './types.js';
import { isWhiteLabelled } from '../utils/whiteLabelling.js';
import { KernelManager, ServerConnection, SessionManager } from '@jupyterlab/services';
import type { JupyterServerSettings } from 'myst-execute';
import { findExistingJupyterServer, launchJupyterServer } from 'myst-execute';
Expand Down Expand Up @@ -104,7 +105,13 @@ export class Session implements ISession {
}

showUpgradeNotice() {
if (this._shownUpgrade || !this._latestVersion || version === this._latestVersion) return;
if (
this._shownUpgrade ||
!this._latestVersion ||
version === this._latestVersion ||
isWhiteLabelled()
)
return;
this.log.info(
logUpdateAvailable({
current: version,
Expand Down

0 comments on commit 6f23a6e

Please sign in to comment.