Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Typst imports can be conflict prone #1597

Merged
merged 1 commit into from
Oct 22, 2024
Merged

🐛 Typst imports can be conflict prone #1597

merged 1 commit into from
Oct 22, 2024

Conversation

rowanc1
Copy link
Member

@rowanc1 rowanc1 commented Oct 22, 2024

No description provided.

Copy link

changeset-bot bot commented Oct 22, 2024

🦋 Changeset detected

Latest commit: 15cdf41

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
jtex Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@fwkoch fwkoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to avoid conflicts if your export is defined in myst.yml. I guess the next step, to prevent all conflicts, would be something like keeping the template files in a separate folder from the content maybe...?

@rowanc1
Copy link
Member Author

rowanc1 commented Oct 22, 2024

I think the actual solution is to rename the exports based on not conflicting with the known template.yml files + (myst-exports.typ in this case).

@rowanc1 rowanc1 merged commit b9de346 into main Oct 22, 2024
7 checks passed
@rowanc1 rowanc1 deleted the feat/imports branch October 22, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants