🧮 Use katex for mathml rendering in jats #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 tasks
rowanc1
reviewed
Jul 31, 2023
There was a problem hiding this comment.
Looks awesome! A few points/questions below.
Can you maintain the latex/cdata in the output using an alternatives? I think it is good to have both included.
Should we move xmlns:mml="http://www.w3.org/1998/Math/MathML" to the top of the document? Is it common to have that throughout?
|
Just saw that the MML that katex gives includes the annotation: <mml:annotation encoding="application/x-tex">w_{t+1} = (1 + r_{t+1}) s(w_t) + y_{t+1}</mml:annotation>I think we may want to remove that in favour of alternatives bundle in JATS? Would need to look at more examples to be sure. |
|
Tested locally, and JATS validation is working well! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the bullet point
Math should be parsed and exported to mmlon this issue: #347JATS export now uses mathml to represent equations / inline math, rather than leaving the raw latex math.