From f17e4b83c5e3c08bdec4eb103b0ab9cd3bc0cbd2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Krassowski?= <5832902+krassowski@users.noreply.github.com> Date: Sat, 14 Mar 2020 11:06:39 +0000 Subject: [PATCH 1/2] Add notes on pyls dependencies issues --- README.md | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index b69dfb67f..b8b3a3751 100644 --- a/README.md +++ b/README.md @@ -153,8 +153,16 @@ Use of a python `virtualenv` or a conda env is also recommended. [Microsoft list](https://microsoft.github.io/language-server-protocol/implementors/servers/) should work after [some additional configuration](./CONTRIBUTING.md#specs). - Note: it may be worth visiting the repository of each server you install as + Note: it is worth visiting the repository of each server you install as many provide additional configuration options. + + Note on pyls (python-language-server) issues: pyls is known to require specific + versions of some dependencies such as [ujson <= 1.35]( + https://github.com/krassowski/jupyterlab-lsp/issues/203#issuecomment-599039556 + ), [jedi == 0.15.2 and parso == 0.5.2]( + https://github.com/krassowski/jupyterlab-lsp/issues/200#issuecomment-599039353 + ). If you experience any issues with LSP functions in Python, + please check if you have the right version using `pip freeze` command. 1. (Optional, Linux/OSX-only) to enable opening files outside of the root directory (the place where you start JupyterLab), create `.lsp_symlink` and @@ -196,7 +204,7 @@ We plan to provide a configuration GUI at some time ([#25](https://github.com/kr #### I want to hide specific diagnostics/inspections/warnings -For example, the Python server that we support by default ([pyls](https://github.com/palantir/python-language-server)) has a [configuration section](https://github.com/palantir/python-language-server#configuration) in ther documentation which refers to the providers of specific features, including `pycodestyle` for inspections/diagnostics. +For example, the Python server that we support by default ([pyls](https://github.com/palantir/python-language-server)) has a [configuration section](https://github.com/palantir/python-language-server#configuration) in their documentation which refers to the providers of specific features, including `pycodestyle` for inspections/diagnostics. The exact configuration details will vary between operating systems (please see the [configuration section of pycodestyle documentation](https://pycodestyle.readthedocs.io/en/latest/intro.html#configuration)), but as an example, on Linux you would simply need to create a file called `~/.config/pycodestyle`, which may look like that: From d1ee498d4df0ca0a721751a3219315d6472f1365 Mon Sep 17 00:00:00 2001 From: krassowski Date: Sat, 14 Mar 2020 11:53:36 +0000 Subject: [PATCH 2/2] Prettier apparently --- README.md | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/README.md b/README.md index b8b3a3751..98f568a2c 100644 --- a/README.md +++ b/README.md @@ -155,13 +155,9 @@ Use of a python `virtualenv` or a conda env is also recommended. Note: it is worth visiting the repository of each server you install as many provide additional configuration options. - + Note on pyls (python-language-server) issues: pyls is known to require specific - versions of some dependencies such as [ujson <= 1.35]( - https://github.com/krassowski/jupyterlab-lsp/issues/203#issuecomment-599039556 - ), [jedi == 0.15.2 and parso == 0.5.2]( - https://github.com/krassowski/jupyterlab-lsp/issues/200#issuecomment-599039353 - ). If you experience any issues with LSP functions in Python, + versions of some dependencies such as [ujson <= 1.35](https://github.com/krassowski/jupyterlab-lsp/issues/203#issuecomment-599039556), [jedi == 0.15.2 and parso == 0.5.2](https://github.com/krassowski/jupyterlab-lsp/issues/200#issuecomment-599039353). If you experience any issues with LSP functions in Python, please check if you have the right version using `pip freeze` command. 1. (Optional, Linux/OSX-only) to enable opening files outside of the root