Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make username configurable in non-collaborative mode #866

Open
dlqqq opened this issue Jun 30, 2024 · 0 comments
Open

Make username configurable in non-collaborative mode #866

dlqqq opened this issue Jun 30, 2024 · 0 comments
Labels
enhancement New feature or request priority
Milestone

Comments

@dlqqq
Copy link
Member

dlqqq commented Jun 30, 2024

Problem

Currently, when jupyter_collaboration is not installed in the environment, we use the getpass.getuser() method to retrieve the username shown instead of the Jupyter Server IdentityProvider. This is because we wanted to avoid showing "Anonymous XYZ" in the chat UI to avoid confusing users who are unfamiliar with the default IdentityProvider implementation, which is typically only used by jupyter_collaboration.

However, some server operators have informed us of use-cases where they have a custom IdentityProvider configured but do not want to install jupyter_collaboration in their deployment environment. Currently there is no way to use the JServer IdentityProvider when jupyter_collaboration is not installed.

Proposed Solution

Implement a new boolean trait on the root AiExtension class via traitlets that ensures the JServer IdentityProvider is always used to retrieve the username and avatar color. I would recommend defining it as

always_use_identity_provider = Bool(..., default_value=False)

on the root AiExtension class.

@dlqqq dlqqq added enhancement New feature or request priority labels Jun 30, 2024
@dlqqq dlqqq added this to the v2.19.0 milestone Jun 30, 2024
@dlqqq dlqqq modified the milestones: v2.19.0, v2.21.0 Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority
Projects
None yet
Development

No branches or pull requests

1 participant