From 90f2816d156f7f146b723d4942c27505d020fd65 Mon Sep 17 00:00:00 2001
From: Sridhar Ratnakumar <srid@srid.ca>
Date: Wed, 13 Sep 2023 11:07:33 -0400
Subject: [PATCH] Adjust order of health checks

---
 crates/nix_health/src/lib.rs | 4 ++--
 src/app/health.rs            | 7 ++++---
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/crates/nix_health/src/lib.rs b/crates/nix_health/src/lib.rs
index 3f42339e..7927584a 100644
--- a/crates/nix_health/src/lib.rs
+++ b/crates/nix_health/src/lib.rs
@@ -41,10 +41,10 @@ impl<'a> IntoIterator for &'a NixHealth {
     /// Return an iterator to iterate on the fields of [NixHealth]
     fn into_iter(self) -> Self::IntoIter {
         let items: Vec<Self::Item> = vec![
+            &self.min_nix_version,
+            &self.flake_enabled,
             &self.max_jobs,
             &self.caches,
-            &self.flake_enabled,
-            &self.min_nix_version,
             &self.trusted_users,
         ];
         items.into_iter()
diff --git a/src/app/health.rs b/src/app/health.rs
index 00eba0f5..d4ef533a 100644
--- a/src/app/health.rs
+++ b/src/app/health.rs
@@ -47,18 +47,19 @@ pub fn NixHealthRoute(cx: Scope) -> impl IntoView {
 fn NixHealthView(cx: Scope, health: NixHealth) -> impl IntoView {
     view! { cx,
         <div class="flex flex-col items-stretch justify-start space-y-8 text-left">
+            // NOTE: Aim to keep this order in alignment with that of the IntoIterator impl
             <ViewCheck name=health.min_nix_version.name() report=health.min_nix_version.report()>
                 <MinNixVersionView v=&health.min_nix_version/>
             </ViewCheck>
+            <ViewCheck name=health.flake_enabled.name() report=health.flake_enabled.report()>
+                <FlakeEnabledView v=&health.flake_enabled/>
+            </ViewCheck>
             <ViewCheck name=health.max_jobs.name() report=health.max_jobs.report()>
                 <MaxJobsView v=&health.max_jobs/>
             </ViewCheck>
             <ViewCheck name=health.caches.name() report=health.caches.report()>
                 <CachesView v=&health.caches/>
             </ViewCheck>
-            <ViewCheck name=health.flake_enabled.name() report=health.flake_enabled.report()>
-                <FlakeEnabledView v=&health.flake_enabled/>
-            </ViewCheck>
             <ViewCheck name=health.trusted_users.name() report=health.trusted_users.report()>
                 <TrustedUsersView v=&health.trusted_users/>
             </ViewCheck>