Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poster image still gets lazy-loaded when setting posterloading to eager #78

Open
jlmmns opened this issue Jan 5, 2023 · 0 comments
Open

Poster image still gets lazy-loaded when setting posterloading to eager #78

jlmmns opened this issue Jan 5, 2023 · 0 comments
Assignees
@justinribeiro
Labels
bug Something isn't working

Comments

@jlmmns
Copy link

jlmmns commented Jan 5, 2023 •
edited
Loading 

<lite-youtube videoid="{{ video }}" posterloading="eager"></lite-youtube>

Results in:

<img id="fallbackPlaceholder" referrerpolicy="origin" loading="lazy" src="..." aria-label="..." alt="...">

I'm using v1.4.0

There seems to be a hard-coded loading="lazy" when the shadow dom gets set up (I guess this is just the default setup):
/blob/main/lite-youtube.ts#L210

Maybe the "fallback" reference isn't working here:
/blob/main/lite-youtube.ts#L323
@justinribeiro justinribeiro self-assigned this Jan 5, 2023
@justinribeiro justinribeiro added the bug Something isn't working label Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justinribeiro justinribeiro

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@justinribeiro @jlmmns