-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove #frame::before
?
#94
Comments
The reason it's there is that it holds the stock YouTube embed look and
feel. In terms of bloat/perf loss, ::before doesn't add weight to the perf
in the traces so I'm inclined to leave it as is.
…On Tue, Jul 25, 2023, 9:41 PM Eli Barzilay ***@***.***> wrote:
It took me a while to realize that the top shadow effect is coming from
here and not from youtube...
Initially I thought about adding another attribute to specify the
gradient, or the whole ::before etc -- but then I remembered this from
CONTRIBUTING.md:
Anything that adds bloat or perf loss won't be accepted [...]
So for myself, I just nuked it, but following the same motto, it seems
fitting to drop it -- if anyone wants to see a shadow, they can add one
themselves, no?
—
Reply to this email directly, view it on GitHub
<#94>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAE5DL7QJVQ7NBDYJIV3333XSCNVXANCNFSM6AAAAAA2X73QWI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
OK, that makes sense (and it did take me a while to realize where that shadow was coming from since it did feel like it's what youtube hands out...). Would you mind adding some |
Ping on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It took me a while to realize that the top shadow effect is coming from here and not from youtube...
Initially I thought about adding another attribute to specify the gradient, or the whole
::before
etc -- but then I remembered this fromCONTRIBUTING.md
:So for myself, I just nuked it, but following the same motto, it seems fitting to drop it -- if anyone wants to see a shadow, they can add one themselves, no?
The text was updated successfully, but these errors were encountered: