Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[request] support for java.time #667

Closed
IARI opened this issue Jun 19, 2021 · 8 comments
Closed

[request] support for java.time #667

IARI opened this issue Jun 19, 2021 · 8 comments

Comments

@IARI
Copy link

IARI commented Jun 19, 2021

I is my understanding that java.util.Date should not be used anymore.
I suggest to add support for java.time.

@bdemers
Copy link
Member

bdemers commented Jun 19, 2021

This will likely be added in v1. The current version of JJWT currently targets Java 7 APIs for Android compatibility (which is why we are still using Date)

I don’t know if I would say, ‘Date’ shouldn’t be used, but I would still much rather use Instant and Duration instead 😀

@lhazlewood
Copy link
Contributor

Internal note: see #308 and #352

@stale stale bot added the stale Stale issues pending deletion due to inactivity label Aug 22, 2021
@bdemers bdemers added this to the 1.0 milestone Aug 22, 2021
@stale stale bot removed the stale Stale issues pending deletion due to inactivity label Aug 22, 2021
@jwtk jwtk deleted a comment from stale bot Aug 22, 2021
@limbic-derek
Copy link

Any updates on this? Seems like a smart API update to me.

@linghengqian
Copy link

Any updates on this? Seems like a smart API update to me.

This should be one of the milestones of 1.0, and judging from the issue distribution 1.0 is still heavy work. At the same time, the 0.11.3 and 0.12.0 milestones still have unresolved issues.

@bdemers
Copy link
Member

bdemers commented Feb 7, 2022

@linghengqian the biggest thing in v1, is the JWE work, if you are interested in helping try it out, please take a look at the jwe branch 😄

@linghengqian
Copy link

@linghengqian the biggest thing in v1, is the JWE work, if you are interested in helping try it out, please take a look at the jwe branch 😄

I feel do not know how to start, for the vast and corresponding PR look it at the end stage, but does not have an issue of what it needs other parts (if I do not understand the function of snoatype-lift wrong, refer to #279 ).

@lhazlewood
Copy link
Contributor

@linghengqian that's true - JWE is large and almost finished, so given the scope, it's probably best to leave the remaining work for JJWT team members. Normally I feel otherwise (anyone should jump in!) but it's a daunting task for jwe to wrap up because it includes so much stuff, like JWK support, key management algorithms, AEAD encryption algorithms, and various interface cleanup additions.

@lhazlewood
Copy link
Contributor

Closing as duplicate of #235 so we can track this in one place

@lhazlewood lhazlewood removed this from the 1.0 milestone Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants