Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dracut immucore should fatal if binaries are missing #2692

Closed
Tracked by #2909
Itxaka opened this issue Jul 3, 2024 · 2 comments · Fixed by kairos-io/immucore#382
Closed
Tracked by #2909

Dracut immucore should fatal if binaries are missing #2692

Itxaka opened this issue Jul 3, 2024 · 2 comments · Fixed by kairos-io/immucore#382
Assignees
Labels
area/immucore bug Something isn't working

Comments

@Itxaka
Copy link
Member

Itxaka commented Jul 3, 2024

#2691 brought up to light that the dracut module setup for immucore does not seem to fail when it fails. In this case it was missing a binary and the initramfs was built anyway with missing binaries.

It should hard fatal if a binary is missing, no 2 way about it, otherwise we can have weird behavior during boot and we wont even notice.

Here is the exact line that was failing but initramfs module was still inserted and initramfs built: https://github.com/kairos-io/immucore/blob/main/dracut/28immucore/module-setup.sh#L28

See related: #2682

@Itxaka Itxaka added bug Something isn't working triage Add this label to issues that should be triaged and prioretized in the next planning call unconfirmed labels Jul 3, 2024
@Itxaka Itxaka added bug Something isn't working area/immucore and removed bug Something isn't working labels Jul 4, 2024
@mudler mudler mentioned this issue Oct 1, 2024
42 tasks
@Itxaka Itxaka self-assigned this Oct 1, 2024
@Itxaka Itxaka removed the unconfirmed label Oct 1, 2024
@Itxaka Itxaka moved this to In Progress 🏃 in 🧙Issue tracking board Oct 1, 2024
@Itxaka Itxaka removed the triage Add this label to issues that should be triaged and prioretized in the next planning call label Oct 1, 2024
@Itxaka Itxaka moved this from In Progress 🏃 to Under review 🔍 in 🧙Issue tracking board Oct 1, 2024
@github-project-automation github-project-automation bot moved this from Under review 🔍 to Done ✅ in 🧙Issue tracking board Oct 1, 2024
@Itxaka Itxaka reopened this Oct 3, 2024
@github-project-automation github-project-automation bot moved this from Done ✅ to Under review 🔍 in 🧙Issue tracking board Oct 3, 2024
@Itxaka
Copy link
Member Author

Itxaka commented Oct 3, 2024

this is waiting for new framework image

@Itxaka
Copy link
Member Author

Itxaka commented Oct 4, 2024

on master

@Itxaka Itxaka closed this as completed Oct 4, 2024
@github-project-automation github-project-automation bot moved this from Under review 🔍 to Done ✅ in 🧙Issue tracking board Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/immucore bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant