Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: substitute disk commands by pure golang #2772

Open
Itxaka opened this issue Jul 29, 2024 · 2 comments
Open

feat: substitute disk commands by pure golang #2772

Itxaka opened this issue Jul 29, 2024 · 2 comments
Labels
area/agent area/immucore enhancement New feature or request triage Add this label to issues that should be triaged and prioretized in the next planning call

Comments

@Itxaka
Copy link
Member

Itxaka commented Jul 29, 2024

Currently we require several binaries both on agent and immucore to exist in the system.

This brings packages that might not be needed after install or that are a commodity (mount can be called directly as a syscall for example)

We should have a look into substituting those by a pure golang implementation like https://github.com/diskfs/go-diskfs

That means:

  • less dependencies in the underlying OS
  • more interoperability between systems (especially libc vs musl)
  • smaller images
  • less points of failure (required binaries on the install image, on the initramfs, probable desync)
@Itxaka Itxaka added enhancement New feature or request area/agent area/immucore triage Add this label to issues that should be triaged and prioretized in the next planning call labels Jul 29, 2024
@Itxaka
Copy link
Member Author

Itxaka commented Jul 29, 2024

potentially we could also build the isos with it but Im not sure it would support all of our options like hybrid isos and such

EDIT: it actually does: https://github.com/diskfs/go-diskfs/blob/master/examples/bootable_iso.go#L44

@Itxaka
Copy link
Member Author

Itxaka commented Oct 7, 2024

part of this is already done with the new partitioner but deps have not been updated.

There is also the thing that yip still requires the binaries, which means the same partitioner changes should be try to move into yip so we can drop more deps from the os images. Currently we could drop binaries from the os image but immucore which uses yip still requires them so no luck there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/agent area/immucore enhancement New feature or request triage Add this label to issues that should be triaged and prioretized in the next planning call
Projects
Status: No status
Development

No branches or pull requests

1 participant