Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make faster/parallelize where possible #69

Open
3 tasks
zenalapp opened this issue Sep 8, 2020 · 1 comment
Open
3 tasks

Make faster/parallelize where possible #69

zenalapp opened this issue Sep 8, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@zenalapp
Copy link

zenalapp commented Sep 8, 2020

  • Only run ancestral reconstruction and permutation test on unique variant patterns (across all genomes), and then un-collapse after computationally intensive steps.
  • Parallelize ancestral reconstruction and the permutaiton test so that hogwash runs faster.
  • Use future.apply if you use the apply family anywhere (you can check out the below link to see how we do it for mikRopML to make it an optional dependency).

Kelly Sovacool implemented something possibly similar as far as parallelization here:

https://github.com/SchlossLab/mikRopML/blob/master/R/utils.R

Example of testing on only unique variant patterns:

var1 1 0 1 1
var2 1 0 1 1
var3 1 0 0 0

In this example, you’d only run var1 and var3 (or var2 and var3) because var1 and var2 have identical patterns so the results should be identical.

@zenalapp zenalapp changed the title Parallelize where possible Make faster/parallelize where possible Sep 9, 2020
@katiesaund katiesaund added the enhancement New feature or request label Sep 14, 2020
@katiesaund
Copy link
Owner

Another way to improve speed for "both" runs - save AR data from phyc and then resuse that data in sync run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants