Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't block ads #68

Open
ImDini opened this issue Aug 31, 2020 · 10 comments
Open

Doesn't block ads #68

ImDini opened this issue Aug 31, 2020 · 10 comments

Comments

@ImDini
Copy link

ImDini commented Aug 31, 2020

After adding it correctly, there is still tons of ads that slip through. Wasn't this list supposed to be updated? I get some ads will come through but it's all..

@kboghdady
Copy link
Owner

kboghdady commented Aug 31, 2020

I just updated some of the ignore list.
I have very few ads which come from a DNS that does redirection to the actual video.
Please try it with the new ignore list

@ImDini
Copy link
Author

ImDini commented Aug 31, 2020

I just updated some of the ignore list.
I have very few ads which come from a DNS that does redirection to the actual video.
Please try it with the new ignore list

Where do we put the ignore list?

@bktiger86
Copy link

I am having the same issue. In the US. When I add the two adlist it blocks everything including the original YouTube video. Any idea why?

@91ajames
Copy link

@bktiger86
after further investigating, I saw this report. Be more helpful if the moder tell users in the readme there are 2 ways to do this which to me found it confusing at first for videos not working when both are enabled. which i hit a few ad videos playing under private chrome for a test while i use firefox the most.
#72

@AdnanHodzic
Copy link

For me not only does this script not block ads, but it also causes infinite loading loops on Youtube.

@bondskin
Copy link

For me not only does this script not block ads, but it also causes infinite loading loops on Youtube.

same with me

@phelix001
Copy link

Fresh clone and getting this error:
/home/pi/youTube_ads_4_pi-hole/youtube.sh: 44: /home/pi/youTube_ads_4_pi-hole/youtube.sh: cannot open ignore.list: No such file

Had to rename ignore.list to ignore.list.bak to get it to work.....I'm guessing it's not ignoring anything now.

@kboghdady
Copy link
Owner

kboghdady commented Dec 23, 2020

@phelix001
you need to change the repoDir ## line # 13
This need to be changed to your actual repo dir on your machine
repoDir='/pi/youTube_ads_4_pi-hole'

@phelix001
Copy link

Yes, I did that.... repoDir='/home/pi/youTube_ads_4_pi-hole'

@Darkepi
Copy link

Darkepi commented Jan 14, 2022

@kboghdady I have checked and my repoDir is correct repoDir='/home/pi/youTube_ads_4_pi-hole' but I am still receiving the error "/home/pi/youTube_ads_4_pi-hole/youtube.sh: 47: cannot open ignore.list: No such file".

Could you help me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants