From 476c29f3d831e02df00e523e7657417f4e7c478a Mon Sep 17 00:00:00 2001 From: Mario Buikhuizen Date: Tue, 23 Jul 2024 17:30:31 +0200 Subject: [PATCH] fix: make the app full height in popout window Use the new class that is also available in a Solara popout window. Keep the styling of #popout-widget-container for backward compatibility with ipypopout<1.3.0. --- jdaviz/main_styles.vue | 8 ++++++-- pyproject.toml | 2 +- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/jdaviz/main_styles.vue b/jdaviz/main_styles.vue index 7962d5fd76..b12646b443 100644 --- a/jdaviz/main_styles.vue +++ b/jdaviz/main_styles.vue @@ -239,12 +239,16 @@ a:active { max-height: calc(100% - 48px); } -#popout-widget-container .v-application.jdaviz { +/* #popout-widget-container line can be removed once users use ipypopout >= 1.3.0 */ +#popout-widget-container .v-application.jdaviz, +.jupyter-widgets-popout-container .v-application.jdaviz { min-height: 100vh; max-height: 100vh; } -#popout-widget-container .jdaviz__content--not-in-notebook { +/* #popout-widget-container line can be removed once users use ipypopout >= 1.3.0 */ +#popout-widget-container .jdaviz__content--not-in-notebook, +.jupyter-widgets-popout-container .jdaviz__content--not-in-notebook { max-height: 100%; } diff --git a/pyproject.toml b/pyproject.toml index 2a8af00147..13e55b2a01 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -21,7 +21,7 @@ dependencies = [ "ipysplitpanes>=0.1.0", "ipygoldenlayout>=0.3.0", "ipywidgets>=8.0.6", - "solara>=1.32", + "solara>=1.36", "pyyaml>=5.4.1", "specutils>=1.15", "specreduce>=1.4.1",