From c6f94f641dda72a2a8c155d50de2a902daaa24c6 Mon Sep 17 00:00:00 2001
From: Rafal Czajkowski <rafal.czajkowski@keep.network>
Date: Wed, 12 Jul 2023 12:27:26 +0200
Subject: [PATCH] Rename fn that converts script to BTC address

The `scriptPubKey` is a field specific to transaction outputs but
basically, this function converts any script to a Bitcoin address. Here
we make this function more generic and rename to
`createAddressFromOutputScript`.
---
 typescript/src/bitcoin.ts       | 2 +-
 typescript/test/bitcoin.test.ts | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/typescript/src/bitcoin.ts b/typescript/src/bitcoin.ts
index ceffb0fca..4abc66599 100644
--- a/typescript/src/bitcoin.ts
+++ b/typescript/src/bitcoin.ts
@@ -633,7 +633,7 @@ export function createOutputScriptFromAddress(address: string): Hex {
  * @param network Bitcoin network.
  * @returns The Bitcoin address.
  */
-export function getAddressFromScriptPubKey(
+export function createAddressFromOutputScript(
   scriptPubKey: string,
   network: BitcoinNetwork = BitcoinNetwork.Mainnet
 ): string {
diff --git a/typescript/test/bitcoin.test.ts b/typescript/test/bitcoin.test.ts
index b581fb78e..ce525b06d 100644
--- a/typescript/test/bitcoin.test.ts
+++ b/typescript/test/bitcoin.test.ts
@@ -12,7 +12,7 @@ import {
   bitsToTarget,
   targetToDifficulty,
   createOutputScriptFromAddress,
-  getAddressFromScriptPubKey,
+  createAddressFromOutputScript,
 } from "../src/bitcoin"
 import { calculateDepositRefundLocktime } from "../src/deposit"
 import { BitcoinNetwork } from "../src/bitcoin-network"
@@ -493,7 +493,7 @@ describe("Bitcoin", () => {
           btcAddresses[bitcoinNetwork as keyof typeof btcAddresses]
         ).forEach(([addressType, { address, scriptPubKey }]) => {
           it(`should return correct ${addressType} address`, () => {
-            const result = getAddressFromScriptPubKey(
+            const result = createAddressFromOutputScript(
               scriptPubKey,
               bitcoinNetwork === "mainnet"
                 ? BitcoinNetwork.Mainnet