Fix private code imported from SW lib

[gaetbout]

// TODO Remove all done, it was copied from Starkware's library. There must be a better way
Fix this todo.

[github-actions]

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍
Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

[gaetbout]

Ping

[github-actions]

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍
Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

[gaetbout]

Pong

[github-actions]

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍
Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

[gaetbout]

.

[harsh-ps-2003]

@gaetbout
I see that because the method is not public in the core library, we have copied the method. I don't get Fix private code imported - its not imported, its defined in the file itself! There must be a better way - so we are trying to reimplement the methods in a better way, so there must be some problem with this copy pasted implementation. Can you elaborate the problem?

A better way to implement this that I can think about is using bitwise left shift directly instead of match statement with hardcoded values for each shift. also directly using the operator will allow us to handle any shift amount (up to max allowed by the type ofc) which would be better than total 31 bytes that we are handling using match. But I think << operator is unavailable! so I might need to have a custom left shift method itself! Wanna see it in a PR? edit: tried it, got a lot of outofgas errors :(

But I don't find anything inherently wrong with this standard implementation itself.

Sorry if the question is dumb, new to Starknet and Cairo in general! Thanks

[gaetbout]

My point is that we shouldn't have function copy pasted from SW repo.
I believe reworking the logic, as you suggested, might be a correct fix.
Or we can ask SW to make that fn public

[harsh-ps-2003]

If SW can make the methods public, that would be sweet!

[github-actions]

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍
Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

[gaetbout]

Ping