Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove Ark dependency in Garaga rs #179

Open
feltroidprime opened this issue Aug 30, 2024 · 7 comments
Open

feat: Remove Ark dependency in Garaga rs #179

feltroidprime opened this issue Aug 30, 2024 · 7 comments
Assignees
Labels
enhancement Enhancement of the code, not introducing new features.

Comments

@feltroidprime
Copy link
Collaborator

feltroidprime commented Aug 30, 2024

Lambdaworks has now BN254 and BLS Fq12 types and pairings implemented in https://github.com/lambdaclass/lambdaworks/tree/main/math/src/elliptic_curve/short_weierstrass/curves

Removing ark would help us having faster and smaller builds, and unified code

@feltroidprime feltroidprime added enhancement Enhancement of the code, not introducing new features. priority-low Nice addition, maybe... someday... labels Aug 30, 2024
@varun-doshi
Copy link

Hi
I would like to work on this...I've previously contributed to Shinigami as well

Copy link

onlydustapp bot commented Sep 8, 2024

Hey @varun-doshi!
Thanks for showing interest.
We've created an application for you to contribute to Garaga.
Go check it out on OnlyDust!

@feltroidprime
Copy link
Collaborator Author

feltroidprime commented Sep 9, 2024

Thanks for the proposition! Please do!
The goal is to adapt the python bindings in tools/garaga_rs that uses ark to replace them with lambaworks, using the existing helpers for serialization / de-serialization in io.rs, and make the hydra CI pass.

To test locally, do maturin --develop and pytest -n auto .

Small adaptation on the python side in hydra/definitions.py might be needed when calling the binding.
Do not hesitate to reach me if needed.

@feltroidprime
Copy link
Collaborator Author

@varun-doshi Hi, any update ? Do you have any issue with it ?

@varun-doshi
Copy link

Hi @feltroidprime
Apologies for the delay
On diving deeper into this issue, it turns out there are many changes required to close this. I'm currently a little squashed on time.
If someone else would like to take this up, that'd be great

@feltroidprime feltroidprime removed the priority-low Nice addition, maybe... someday... label Sep 27, 2024
@feltroidprime
Copy link
Collaborator Author

feltroidprime commented Sep 27, 2024

All right. Thx for update.
Open to contrib.

@bacharif
Copy link
Collaborator

I'm taking it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of the code, not introducing new features.
Projects
None yet
Development

No branches or pull requests

3 participants