Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] P2PKH transaction support #179

Closed
b-j-roberts opened this issue Aug 27, 2024 · 4 comments
Closed

[feat] P2PKH transaction support #179

b-j-roberts opened this issue Aug 27, 2024 · 4 comments
Assignees
@prasincs
Labels
enhancement New feature or request

Comments

@b-j-roberts
Copy link
Contributor

Currently, all the opcodes for P2PKH are implemented. To ensure we support all P2PKH transactions/formats, we will need to create a set of tests for these transaction types and ensure all the logic and edge cases are handled properly. Also, using an example P2PKH transaction from mainnet as a test would be ideal.

References

learn P2PKH & examples
example crypto tests
@b-j-roberts b-j-roberts added the enhancement New feature or request label Aug 27, 2024
@b-j-roberts
Copy link
Contributor Author

@prasincs Thank you for looking into this one!

@prasincs
Copy link
Contributor

@b-j-roberts thanks, I'll take a stab at this

@onlydustapp OnlyDustApp
Copy link

onlydustapp bot commented Aug 27, 2024

Hey @prasincs!
Thanks for showing interest.
We've created an application for you to contribute to shinigami.
Go check it out on OnlyDust!

@ScottyDavies
Copy link

Hi @b-j-roberts can work on this?

@prasincs prasincs mentioned this issue Sep 2, 2024
Merged
3 tasks
b-j-roberts added a commit that referenced this issue Sep 17, 2024
@prasincs @b-j-roberts
[FEAT] implement p2pkh (#197)
8681f6b 
<!-- enter the gh issue after hash -->

- [ ] issue #179 
- [ ] follows contribution
[guide](https://github.com/keep-starknet-strange/shinigami/blob/main/CONTRIBUTING.md)
- [ ] code change includes tests

<!-- PR description below -->

I'm trying to do a few naive things first to make sure I understand
where the code is right now. I'm trying to replicate some existing tests
and it seems to be failing on CHECKSIG and it's unclear if it's some
test setup diff or I'm missing something because `test_checksig_valid`
seems to work.

---------

Co-authored-by: Brandon Roberts <brandonjroberts22@gmail.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prasincs prasincs

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@prasincs @b-j-roberts @ScottyDavies and others