Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dev] [optimization] 'while i < n' to 'while x != n' #207

Open
b-j-roberts opened this issue Sep 11, 2024 · 12 comments · May be fixed by #210
Open

[dev] [optimization] 'while i < n' to 'while x != n' #207

b-j-roberts opened this issue Sep 11, 2024 · 12 comments · May be fixed by #210
Assignees
@jsandinoDev
Labels
enhancement New feature or request

Comments

@b-j-roberts
Copy link
Contributor

b-j-roberts commented Sep 11, 2024 •
edited
Loading

To optimize shinigami, we should be using while x != n instead of while i < n when doing loops over a range. So for each instance in the code where a while i < n type loop is used, if possible, we should change them to use while x != n.

References

Example of location to optimize in the code
@b-j-roberts b-j-roberts added the enhancement New feature or request label Sep 11, 2024
@jsandinoDev
Copy link
Contributor

Hi @b-j-roberts can I work on this?

@onlydustapp OnlyDustApp
Copy link

onlydustapp bot commented Sep 11, 2024

Hey @jsandinoDev!
Thanks for showing interest.
We've created an application for you to contribute to shinigami.
Go check it out on OnlyDust!

@raizo07
Copy link

raizo07 commented Sep 11, 2024

@b-j-roberts can I work on this?

@onlydustapp OnlyDustApp
Copy link

onlydustapp bot commented Sep 11, 2024

Hey @raizo07!
Thanks for showing interest.
We've created an application for you to contribute to shinigami.
Go check it out on OnlyDust!

@Jemiiah
Copy link
Contributor

Jemiiah commented Sep 11, 2024

@b-j-roberts I would love to work on this

@onlydustapp OnlyDustApp
Copy link

onlydustapp bot commented Sep 11, 2024

Hey @Jemiiah!
Thanks for showing interest.
We've created an application for you to contribute to shinigami.
Go check it out on OnlyDust!

@Gift-Naomi
Copy link
Contributor

@b-j-roberts can I work on this?

@onlydustapp OnlyDustApp
Copy link

onlydustapp bot commented Sep 11, 2024

Hey @Gift-Naomi!
Thanks for showing interest.
We've created an application for you to contribute to shinigami.
Go check it out on OnlyDust!

@ShantelPeters
Copy link
Contributor

Hi @b-j-roberts can I take this up ?

@onlydustapp OnlyDustApp
Copy link

onlydustapp bot commented Sep 11, 2024

Hey @ShantelPeters!
Thanks for showing interest.
We've created an application for you to contribute to shinigami.
Go check it out on OnlyDust!

@b-j-roberts
Copy link
Contributor Author

Hi @b-j-roberts can I work on this?

Definitely, let me know if you have questions or issues. I'll assign now

@b-j-roberts
Copy link
Contributor Author

@jsandinoDev Just assigned you 🚀

@jsandinoDev jsandinoDev linked a pull request Sep 12, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsandinoDev jsandinoDev

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

'while i < n' to 'while x != n' code optimization jsandinoDev/shinigami
6 participants
@jsandinoDev @b-j-roberts @raizo07 @Gift-Naomi @Jemiiah @ShantelPeters