Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev] [optimization] 'while i < data.len()' to 'let data_len = data.len()' #208

Open
b-j-roberts opened this issue Sep 11, 2024 · 12 comments · May be fixed by #218
Open

[dev] [optimization] 'while i < data.len()' to 'let data_len = data.len()' #208

b-j-roberts opened this issue Sep 11, 2024 · 12 comments · May be fixed by #218
Assignees
Labels
enhancement New feature or request

Comments

@b-j-roberts
Copy link
Contributor

To optimize shinigami, we should be using let data_len = data.len(); while i < data_len instead of while i < data.len() when doing loops over a range. So for each instance in the code where a while i < data.len() type loop is used, if possible, we should change them to use let data_len = data.len(); while i < data_len.

References

Example of location to optimize in the code

@b-j-roberts b-j-roberts added the enhancement New feature or request label Sep 11, 2024
@Iwueseiter
Copy link
Contributor

Hi @b-j-roberts can I work on this?

Copy link

onlydustapp bot commented Sep 11, 2024

Hey @Iwueseiter!
Thanks for showing interest.
We've created an application for you to contribute to shinigami.
Go check it out on OnlyDust!

@raizo07
Copy link

raizo07 commented Sep 11, 2024

@b-j-roberts can I work on this

Copy link

onlydustapp bot commented Sep 11, 2024

Hey @raizo07!
Thanks for showing interest.
We've created an application for you to contribute to shinigami.
Go check it out on OnlyDust!

@Gift-Naomi
Copy link
Contributor

@b-j-roberts can I work on this?

Copy link

onlydustapp bot commented Sep 11, 2024

Hey @Gift-Naomi!
Thanks for showing interest.
We've created an application for you to contribute to shinigami.
Go check it out on OnlyDust!

@manlikeHB
Copy link
Contributor

can i work on this?

Copy link

onlydustapp bot commented Sep 11, 2024

Hey @manlikeHB!
Thanks for showing interest.
We've created an application for you to contribute to shinigami.
Go check it out on OnlyDust!

@ShantelPeters
Copy link
Contributor

I will like to work on this

Copy link

onlydustapp bot commented Sep 11, 2024

Hey @ShantelPeters!
Thanks for showing interest.
We've created an application for you to contribute to shinigami.
Go check it out on OnlyDust!

@b-j-roberts
Copy link
Contributor Author

@b-j-roberts can I work on this?

Yes, I will assign you and check back in a couple days. Please lmk if you have any questions

@b-j-roberts
Copy link
Contributor Author

@Gift-Naomi Assigned 🚀

@Gift-Naomi Gift-Naomi linked a pull request Sep 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants