-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dev] [optimization] 'while i < data.len()' to 'let data_len = data.len()' #208
Comments
Hi @b-j-roberts can I work on this? |
Hey @Iwueseiter! |
@b-j-roberts can I work on this |
@b-j-roberts can I work on this? |
Hey @Gift-Naomi! |
can i work on this? |
Hey @manlikeHB! |
I will like to work on this |
Hey @ShantelPeters! |
Yes, I will assign you and check back in a couple days. Please lmk if you have any questions |
@Gift-Naomi Assigned 🚀 |
To optimize shinigami, we should be using
let data_len = data.len(); while i < data_len
instead ofwhile i < data.len()
when doing loops over a range. So for each instance in the code where awhile i < data.len()
type loop is used, if possible, we should change them to uselet data_len = data.len(); while i < data_len
.References
Example of location to optimize in the code
The text was updated successfully, but these errors were encountered: