Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create an account #33

Closed
2 tasks done
Tracked by #24
trbutler4 opened this issue Aug 11, 2024 · 9 comments
Closed
2 tasks done
Tracked by #24

create an account #33

trbutler4 opened this issue Aug 11, 2024 · 9 comments

Comments

@trbutler4
Copy link
Collaborator

trbutler4 commented Aug 11, 2024

TODO:

@zintarh
Copy link
Contributor

zintarh commented Aug 12, 2024

Hi @trbutler4, I would love to work on this

Copy link

onlydustapp bot commented Aug 12, 2024

Hey @kateberryd!
Thanks for showing interest.
We've created an application for you to contribute to Starknet Phone.
Go check it out on OnlyDust!

@trbutler4
Copy link
Collaborator Author

trbutler4 commented Aug 25, 2024

Hi @trbutler4, I would love to work on this

Do you think you can do both the design and implementation? Basically we will need to add a "create account" flow to the wallet app if the account does not already exist. I can also break this up into two issues (one for design and one for implementation). For the implementation we will want to add a Java class that will be implemented in Rust (please lmk if you are unsure how this will work, there is a walkthrough in the docs but it in not intuitive)

@zintarh
Copy link
Contributor

zintarh commented Aug 25, 2024

@trbutler4, sure, I can handle both the design and implementation. Please break it down into two issues so I can start with the design first and move on to implementation once the design is approved.

@trbutler4
Copy link
Collaborator Author

@trbutler4, sure, I can handle both the design and implementation. Please break it down into two issues so I can start with the design first and move on to implementation once the design is approved.

sure thing

@zintarh
Copy link
Contributor

zintarh commented Aug 25, 2024

Thank you

@trbutler4
Copy link
Collaborator Author

trbutler4 commented Aug 25, 2024

Thank you

you can add on to the current figma, ill paste a link here and on #49

@zintarh
Copy link
Contributor

zintarh commented Aug 25, 2024

Alright. I will do that

@trbutler4
Copy link
Collaborator Author

https://www.figma.com/design/grCm6Jpi2XsQnbAHHE2oCZ/Starknet-Phone-Wallet-App?node-id=0-1&t=0CBRsFd0RF6a9Wws-1

here is the link to the figma. Please request edit access once you are in it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants