Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add minimal logging to example rust native library #66

Closed
trbutler4 opened this issue Aug 27, 2024 · 11 comments
Closed

[feat] Add minimal logging to example rust native library #66

trbutler4 opened this issue Aug 27, 2024 · 11 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@trbutler4
Copy link
Collaborator

trbutler4 commented Aug 27, 2024

Create a new example called rust_android_logging based on the current example app

References

Android rust logging ref

@trbutler4 trbutler4 added the good first issue Good for newcomers label Aug 28, 2024
@ScottyDavies
Copy link

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I have a solid background in Android development and Rust programming, My experience will ensure a seamless and efficient implementation of the rust_android_logging example.

How I plan on tackling this issue

I will implement the task with the following steps!

Initialize a new Rust library project and add logging dependencies in Cargo.toml then Implement logging functions in src/lib.rs and export them with #[no_mangle].

Compile for Android:
Use cargo-ndk to cross-compile the Rust code for Android architectures.

Integrate with Android:
Add the compiled Rust library to your Android project’s jniLibs.
Create a JNI wrapper in Java to call the Rust logging functions.

Build and Test:
Compile the Android project and test logging functionality in the app.

@gadyrcdz
Copy link

Hello @trbutler4! , I was reading about this project and if it is still available I'd like to take it and work on it. Also, I am part of Dojo Coding if this helps me.
Let me now, thank you!

Copy link

onlydustapp bot commented Aug 29, 2024

Hey @gadyrcdz!
Thanks for showing interest.
We've created an application for you to contribute to Starknet Phone.
Go check it out on OnlyDust!

@trbutler4
Copy link
Collaborator Author

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I have a solid background in Android development and Rust programming, My experience will ensure a seamless and efficient implementation of the rust_android_logging example.

How I plan on tackling this issue

I will implement the task with the following steps!

Initialize a new Rust library project and add logging dependencies in Cargo.toml then Implement logging functions in src/lib.rs and export them with #[no_mangle].

Compile for Android: Use cargo-ndk to cross-compile the Rust code for Android architectures.

Integrate with Android: Add the compiled Rust library to your Android project’s jniLibs. Create a JNI wrapper in Java to call the Rust logging functions.

Build and Test: Compile the Android project and test logging functionality in the app.

Perfect. This is exactly what needs to be done. Assigned!

@trbutler4
Copy link
Collaborator Author

Hello @trbutler4! , I was reading about this project and if it is still available I'd like to take it and work on it. Also, I am part of Dojo Coding if this helps me. Let me now, thank you!

Im Assinged this one to @ScottyDavies. Please join our telegram to join in the discussion :)

@trbutler4
Copy link
Collaborator Author

@ScottyDavies any progress on this issue?

@ScottyDavies
Copy link

Yes, I have had multiple progress and would be done latest Tuesday.

@ScottyDavies
Copy link

ScottyDavies commented Sep 23, 2024

@trbutler4 you can check it out and accept the pull request

@trbutler4
Copy link
Collaborator Author

trbutler4 commented Oct 1, 2024

@trbutler4 you can check it out and accept the pull request

Thank you! I requested changes on it. Apart from the "target" directories that should be added to ignore list, Seems like there are a lot of unrelated changes?

@ScottyDavies
Copy link

I am already working on the changes, I would soon be done

@trbutler4
Copy link
Collaborator Author

closing, this is not needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants