Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Reorganize tests to make them easier to add, extend #67

Open
Tracked by #61
vkryukov opened this issue Nov 13, 2024 · 1 comment
Open
Tracked by #61

Proposal: Reorganize tests to make them easier to add, extend #67

vkryukov opened this issue Nov 13, 2024 · 1 comment

Comments

@vkryukov
Copy link
Contributor

vkryukov commented Nov 13, 2024

I would like to reorganize tests a-la Readability.js test suite:

  • every fixture lives in it's own folder
  • folder contains source.html and expected.html, possibly along with expected.txt
  • folder contains a expected_meta.json with all other metadata (such as authors, published_at) generated by readable

Potential benefits:

  • easier to port over tests from Readability.js
  • easier to add large html files
  • can extend to support different Floki HTML parsers and account for differences between them

Thoughts @Valian ?

@Valian
Copy link
Collaborator

Valian commented Nov 13, 2024

Green light from me! I'm not able to do it by myself because of lack of time, but I'd gladly accept all your contributions and help as much as I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants