Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --deregister-max-parallel terminations #39

Open
eytan-avisror opened this issue Jan 15, 2020 · 1 comment
Open

Support --deregister-max-parallel terminations #39

eytan-avisror opened this issue Jan 15, 2020 · 1 comment

Comments

@eytan-avisror
Copy link
Collaborator

In very large clusters with many target groups, we may want to 'batch' terminations so that we do not work on more than N instances at the same time.

When we get a hook we should start the worker that sends heartbeat, but possibly queue it until a slot is available.

For example,
With 500+ target groups, and 20 concurrent terminations, lifecycle-manager might have a hard time making progress, however if we only work on 5 instances at a time, performance of overall systems might be better.

We should take a controller flag --deregister-max-parallel and hold-off on deregistering any instance over N in parallel

@eytan-avisror
Copy link
Collaborator Author

Related #35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant