Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the litmus-service to keptn-contrib #35

Open
ksatchit opened this issue Mar 31, 2021 · 2 comments
Open

Move the litmus-service to keptn-contrib #35

ksatchit opened this issue Mar 31, 2021 · 2 comments
Labels
question Further information is requested

Comments

@ksatchit
Copy link
Collaborator

The litmus-service has seen useful changes since the initial release (as can be gauged from these closed issues).

It has generated some positive community response (as seen from joint blogs and webinars) and seen initial adoption.

On behalf of the team working on this integration, would like to propose that litmus-service be moved to the next-stage of usage/recognition, i.e., be included into keptn-contrib.

We would be happy to understand any other requirements that need to be met for this and try to facilitate the same.

@ksatchit ksatchit added the question Further information is requested label Mar 31, 2021
@ksatchit
Copy link
Collaborator Author

cc: @jetzlstorfer

@christian-kreuzberger-dtx
Copy link
Contributor

christian-kreuzberger-dtx commented Apr 21, 2021

FYI: https://github.com/keptn-sandbox/contributing#how-to-be-promoted-to-keptn-contrib-organization

In my opinion unit tests would be great before promoting to keptn-contrib.
edit: Example for unit tests: https://github.com/keptn-sandbox/keptn-service-template-go/blob/1562765b151bf008b083e4b543854d9600489555/eventhandler_test.go#L44-L78

Other then that, I'm happy to be the sponsor from the keptn core team. I like litmus-service and the way it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants