Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add healthcheck_repo setting option #154

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aliceinwire
Copy link
Member

@aliceinwire aliceinwire commented Jul 13, 2022

This commit add the setting option healthcheck_repo useful for using a personalized healthcheck repository.
example on boards.yaml in the master settings:
healthcheck_repo: https://github.com/aliceinwire/lava-healthchecks-binary.git

This will use the https://github.com/aliceinwire/lava-healthchecks-binary.git repository instead of the default https://github.com/baylibre/lava-healthchecks-binary.git

@aliceinwire aliceinwire changed the title Add healthcheck_repo command for changing the healthcheck repository Add healthcheck_repo setting option Jul 13, 2022
@aliceinwire
Copy link
Member Author

aliceinwire commented Jul 20, 2022

This pull request depend on https://github.com/aliceinwire/lava-healthchecks-binary.git as new base for lava healthchecks as the repository is re-formatted for this pull request.
the new repository style will be:

lava-healthchecks-binary.git/ # root of the repository
-> /healthchecks  # where to put healthcheck binary
-> /Dockerfile
-> /README.md
-> /              # where to put scripts not relevant to healthcheck binary

This also follow the format v0.1 of the lava-healthchecks-binary
repository explained here under:
lava-healthchecks-binary.git/ # root of the repository
-> /healthchecks  # where to put healthcheck binary
-> /Dockerfile
-> /README.md
-> /  # where to put scripts not relevant to healthcheck binary

Signed-off-by: Alice Ferrazzi <alice.ferrazzi@miraclelinux.com>
Signed-off-by: Alice Ferrazzi <alice.ferrazzi@miraclelinux.com>
@aliceinwire
Copy link
Member Author

aliceinwire commented Jul 26, 2022

patch v2

@aliceinwire
Copy link
Member Author

aliceinwire commented Aug 22, 2023

still waiting for this to be merged... currently handling of healthcheck_repo is not taking in account any local only board healthcheck binary

@montjoie
Copy link
Collaborator

Sorry for the delay, Could you rebase and push, so that all self tests will be done

@@ -1,13 +1,10 @@
FROM bitnami/minideb:stretch

RUN apt-get update && apt-get -y install git
RUN git clone https://github.com/BayLibre/lava-healthchecks-binary.git
RUN git clone https://github.com/kernelci/lava-healthchecks-binary.git lava-healthchecks-binary
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repository do not exists. And lava-docker will migrate off kernelci to baylibre soon.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I thought it was going to gitlab.com under the Linaro / LAVA org?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since lava-docker is not a Linaro project, it is easier to go to baylibre. It will requires less "spetial rigths".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants