Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mtl generated by trimesh not removed, texture removed instead #21

Open
dm-mattyoung opened this issue Aug 3, 2023 · 1 comment
Open

mtl generated by trimesh not removed, texture removed instead #21

dm-mattyoung opened this issue Aug 3, 2023 · 1 comment

Comments

@dm-mattyoung
Copy link

This line appears to be the issue:
https://github.com/kevinzakka/obj2mjcf/blob/main/obj2mjcf/_cli.py#L376

Trimesh is generating an mtl file called material.mtl, maybe this changed.

This is missed by "material_0" in x.name, which instead deletes any material_0.png files that have been generated.

Could pass a special name into mtl_name in trimesh.export and only clean up those after.
@kevinzakka
Copy link
Owner

Hi @dm-mattyoung, would you mind making a PR if you have time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevinzakka @dm-mattyoung