Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Pull Unidentified styles into global stylesheet space and out of compiled scoped svelte #637

Open
kgar opened this issue Jun 7, 2024 · 0 comments
Labels
style Style changes are needed

Comments

@kgar
Copy link
Owner

kgar commented Jun 7, 2024

When someone wants to reuse the Unidentified UI from Tidy, it is currently inaccessible because of the styles being scoped and compiled by svelte.

Consider moving these styles into the global stylesheet space, under .tidy5e-sheet.

From the community:

For me it would be by far the easiest to have the tidy5e global stylesheet do the work. I'm using the handlebars extension from the dnd5e system for producing the unidentified div. Changing that would be a lot more work than just hooking the system's way of doing it.
Adding this to the global stylesheet would mean that other modules made for the dnd5e character sheet would have a similar easy time to display any added item tabs in tidy5e.

https://discord.com/channels/1167985253072257115/1247504691609469028/1248266049925681255

@kgar kgar added the style Style changes are needed label Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
style Style changes are needed
Projects
None yet
Development

No branches or pull requests

1 participant