Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Danger #85

Open
squarefrog opened this issue Mar 1, 2019 · 3 comments
Open

Add support for Danger #85

squarefrog opened this issue Mar 1, 2019 · 3 comments

Comments

@squarefrog
Copy link
Contributor

As noted in #83 (comment) it may be useful for someone to setup Danger.

This would automate the initial QA of a Pull Request. It's easy to forget things sometimes, so this could automatically check the following:

  • Does SwiftLint pass?
  • Does it change significant parts of the app without unit tests?
  • Is the new code missing comments?
  • Have you updated the CHANGELOG?
  • Did you accidentally include a copyright header?

This would probably need the project owner to setup, as it relies on a GitHub bot to run automatically. See Getting Started.

@RJ-Clegg
Copy link
Collaborator

RJ-Clegg commented Mar 5, 2019

@kgellci IS this something you need to do? Or could I do this?
I'd love to give this a go as I haven't used Danger before.

@kgellci
Copy link
Owner

kgellci commented Mar 5, 2019 via email

@RJ-Clegg
Copy link
Collaborator

RJ-Clegg commented Mar 9, 2019

After looking into this (And setting it up on another project) I am in agreement with @squarefrog - This needs to be setup by the project owner. @kgellci Do you want to take over this task?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants