Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trtAssign return integer or factor #151

Open
elinsooon opened this issue May 6, 2022 · 2 comments
Open

trtAssign return integer or factor #151

elinsooon opened this issue May 6, 2022 · 2 comments
Assignees
@elinsooon
Labels
bug

Comments

@elinsooon
Copy link
Contributor

fix trtAssign to return type factor (or integer)
@kgoldfeld kgoldfeld assigned kgoldfeld and elinsooon and unassigned kgoldfeld May 6, 2022
@kgoldfeld kgoldfeld added the bug label May 6, 2022
@elinsooon
Copy link
Contributor Author

is it sufficient for trtAssign to just return type integers? Once it's in this form it can be easily coerced to type factor, correct? If it is sufficient, we can close this issue

@kgoldfeld
Copy link
Owner

I don't think it would be a great idea to force it to be a factor at this point, because it might mess with some existing user code, but we might want to consider adding an explicit argument to create a factor (e.g. asFactor). So, maybe we can keep it open for now in case we decide to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elinsooon elinsooon

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kgoldfeld @elinsooon