Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncated Distributions #78

Open
assignUser opened this issue Oct 27, 2020 · 3 comments
Open

Truncated Distributions #78

assignUser opened this issue Oct 27, 2020 · 3 comments
Labels
feature feature request or enhancement

Comments

@assignUser
Copy link
Collaborator

No description provided.

@assignUser assignUser added the feature feature request or enhancement label Oct 28, 2020
@assignUser
Copy link
Collaborator Author

I think it would be nicer to add another field/parameter for the truncated distributions rather than doubling up all distributions as dist_trunc. It would maybe be a good time to do the switch to parameter names without inherent meaning, but this would be potentially a breaking change (we could possibly implement it in a way that is backwards compatible but I am not sure how well that would work). So we should think about this carefully.

@kgoldfeld
Copy link
Owner

I agree - it is nice to have a motivating reason to do this, other than the fact that using "variance" to refer to a dispersion parameter or, even worse, the number of trials in a binomial trial seems reason enough.

As far as implementing the change to param1/param2/param3, seems like a perfect kind of challenge for you - how to transition gracefully from ill-considered non-professional interface to a more professional one.

@assignUser
Copy link
Collaborator Author

And another issue to consider when designing the changes for #75 (I'm going through and linking these issues so we don't lose track :) )

@assignUser assignUser added this to the Simstudy 1.0(?) milestone Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature feature request or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants