Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow alternative distribution names #82

Open
assignUser opened this issue Oct 28, 2020 · 6 comments
Open

Allow alternative distribution names #82

assignUser opened this issue Oct 28, 2020 · 6 comments
Labels
docs an issue concerning the documentation feature feature request or enhancement

Comments

@assignUser
Copy link
Collaborator

  • bernoulli as "standard" alternative to binary
  • gaussian as "standard" alternative to normal
@assignUser assignUser added docs an issue concerning the documentation feature feature request or enhancement labels Oct 28, 2020
@assignUser
Copy link
Collaborator Author

assignUser commented Oct 29, 2020

I am not sure about this one, there is quite a bit of code dependent on the names other than just the generate stuff, so there is a large potential for introducing errors now and down the line.

Maybe a better approach would be to add the names to the documentation That is already the case with the new overview vignette.

Let me know what you think.

@kgoldfeld
Copy link
Owner

I am not saying this is the most crucial thing, but what if we just added two new distributions that happen to act just like two existing distributions? So, we wouldn't break anything internally.

@assignUser
Copy link
Collaborator Author

that would not really change anything^^
The issue is not with integrating the new distribution names in the generate chain, that's rather easy. But there are a quite a few checks like this spread around that we would also need to adjust:
image

@kgoldfeld
Copy link
Owner

But what if I said we want to introduce a new distribution, say the Weibull distribution - would you make the same argument?

@assignUser
Copy link
Collaborator Author

In a way you are right, I will check out what the dependencies are exactly and think about how to best proceed.

@assignUser
Copy link
Collaborator Author

This is another issue that would benefit from the switch to r-expressions #75 as these dependencies I mention here would basically all go away,

@assignUser assignUser added this to the Simstudy 1.0(?) milestone Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs an issue concerning the documentation feature feature request or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants