Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Button Shortcut property #8

Open
cbscribe opened this issue Sep 4, 2017 · 4 comments
Open

Use Button Shortcut property #8

cbscribe opened this issue Sep 4, 2017 · 4 comments
Labels

Comments

@cbscribe
Copy link
Member

cbscribe commented Sep 4, 2017

Suggestion from Lars:
The workaround where you manually call emit_signal("pressed") on the StartButton is not necessary. Buttons have a Shortcut property in the inspector where you can define what action can be used to press that button.

@cbscribe
Copy link
Member Author

cbscribe commented Sep 4, 2017

Setting the Shortcut property is complex too. Maybe just remove this entirely - is pressing space to start necessary?

@Warlaan
Copy link

Warlaan commented Sep 5, 2017

I'd prefer leaving it out altogether to using script code. A property has exactly one place and exactly one purpose. Script code could go pretty much anywhere and could do pretty much anything, so it will statistically introduce more bugs and will be harder to debug.

How about visually showing that this step is optional? For example you could use a shaded box like for the "Tip"-elements. Or even link to a new page if you worry that it might look complicated enough to demotivate people.

@cbscribe
Copy link
Member Author

Well, I've confirmed that the button ShortCut property is currently broken in 3.0. I'll keep an eye on this and hopefully by release we'll be able to use it.

@Warlaan
Copy link

Warlaan commented Sep 12, 2017

That's unfortunate. On first sight it looked fixed since in version 2.1.x even setting a shortcut didn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants