Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current selected profile notification #601

Open
artjomsR opened this issue Dec 29, 2024 · 1 comment
Open

Current selected profile notification #601

artjomsR opened this issue Dec 29, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@artjomsR
Copy link
Contributor

artjomsR commented Dec 29, 2024

Is your feature request related to a problem? Please describe.
Recently I've set up 2 profiles in the player, and it's happened several times already where I've mined a few cards, only to realise I've had the wrong profile selected. This results in me having to go back to these recently created cards and "fix" them.

Describe the solution you'd like
I think it'd be good to have some sort of notification / confirmation to indicate the currently selected profile. This would make it more obvious and minimise the number of such mistakes, where the wrong profile is selected

Describe alternatives you've considered
The notification could be displayed:

  • On the subtitle load popup. E.g. Currently selected profile: XYZ above the `Subtitles must be loaded before you can start mining.
  • Display a new popup after loading the subtitles using the standard notification, e.g. ASB player extension successfully loaded using profile XYZ

Happy to add this myself if we're happy with the text / its location

@killergerbah
Copy link
Owner

killergerbah commented Dec 31, 2024

This is a good idea and I think both places you suggested make sense, especially the "loaded" notification, since that will account for all users including those who drag and drop subtitle files.

But I think just adding info to the existing message might be too simplistic because there the "loaded" message already takes a lot of space. I would suggest applying a max length to the displayed message, truncating the subtitle file name using elipses...
Then something short and simple afterwards like "Profile: xyz" only if a non default profile is being used.

About the subtitle track selector dialog, I think this also requires thought but I dont know of a great solution. I would like the selected profile + settings button to be somewhat close together since those are related. Your suggestion to add it to the dialog content also makes sense but that text is a little far from the settings button.

@killergerbah killergerbah added the enhancement New feature or request label Dec 31, 2024
@killergerbah killergerbah added this to the Extension v1.9.0 milestone Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants