Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for modern Ember #104

Open
chriskrycho opened this issue May 10, 2021 · 0 comments
Open

Update for modern Ember #104

chriskrycho opened this issue May 10, 2021 · 0 comments

Comments

@chriskrycho
Copy link

The current implementation has worked well for a long time, but:

  • it won't work with Ember 4, since the Ember global has been deprecated
  • I think everything this needs to do in terms of lifecycle behavior (and probably quite a bit of the rest of it) can actually be done with public API now, via the router service events
  • There's a fair bit of code in here that exists only to support Ember <2.0.0, which can also be safely dropped

An alternative approach might be: deprecate this in favor of the framework-supplied ember-page-title addon, which supports much of the same behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant