Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing on 2.18 #68

Open
chriskrycho opened this issue Jan 11, 2018 · 5 comments
Open

Failing on 2.18 #68

chriskrycho opened this issue Jan 11, 2018 · 5 comments

Comments

@chriskrycho
Copy link

With 2.17.2 and earlier, everything worked without issue.

Upon upgrading to 2.18.0, the title method never gets invoked.

@mike183
Copy link

mike183 commented Jan 12, 2018

I'm using it with Ember / EmberCLI 2.18.0 without issue, albeit via prember/fastboot.

Not sure if you're also using ember-cli-head or not, but if so, upgrading from v0.3.x to v0.4.x did require some further changes, see here.

@chriskrycho
Copy link
Author

Interesting. We're not using it directly, but ember-cli-meta-tags uses it, and there's an open PR over there for that upgrade, so I'll check and see if that's related.

@kimroen
Copy link
Owner

kimroen commented Apr 2, 2018

@chriskrycho Did you figure out if this was a problem in ember-cli-document-title directly?

@chriskrycho
Copy link
Author

@kimroen I haven’t been back to it, in truth. Been super busy. Hoping to upgrade us in a week or two. I’ll let you know then what I see.

@snewcomer
Copy link
Collaborator

snewcomer commented Apr 19, 2018

I put in a request to see if he could add me as a collaborator on ember-cli-meta-tags. Hasn't been much activity on those libs so hopefully we can get a response! ¯_(ツ)_/¯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants