Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA]: merge measurement-classes #240

Open
kitsudaiki opened this issue Nov 18, 2023 · 0 comments
Open

[QA]: merge measurement-classes #240

kitsudaiki opened this issue Nov 18, 2023 · 0 comments
Labels
L: ★☆☆ Expect low difficulty QA Any tasks, witch improve the quality of the code, documentation and so on
Milestone

Comments

@kitsudaiki
Copy link
Owner

QA

Description

At the moment each measurement (cpu-temperature, cpu-speed and power-consumption) has its own class with its own threads to collect the data. This is totally unnecessary. All measurements should be collected by one single thread.

related files:

https://github.com/kitsudaiki/Hanami/blob/develop/src/libraries/hanami_hardware/src/power_measuring.cpp
https://github.com/kitsudaiki/Hanami/blob/develop/src/libraries/hanami_hardware/src/speed_measuring.cpp
https://github.com/kitsudaiki/Hanami/blob/develop/src/libraries/hanami_hardware/src/temperature_measuring.cpp

Acceptance Criteria

  1. all linked classes are combined into one to collect all data by one thread
  2. the data are still separately stored in different container

Additional Information

Blocked by

How to test

@kitsudaiki kitsudaiki added the QA Any tasks, witch improve the quality of the code, documentation and so on label Nov 18, 2023
@kitsudaiki kitsudaiki added this to the 0.4.0 milestone Nov 18, 2023
@kitsudaiki kitsudaiki modified the milestones: 0.4.0, 0.5.0 Jan 13, 2024
@kitsudaiki kitsudaiki added the L: ★☆☆ Expect low difficulty label Jan 15, 2024
@kitsudaiki kitsudaiki modified the milestones: 0.5.0, 0.6.0 Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: ★☆☆ Expect low difficulty QA Any tasks, witch improve the quality of the code, documentation and so on
Projects
Status: No status
Development

No branches or pull requests

1 participant