Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: configure max amount of used memory #316

Closed
kitsudaiki opened this issue Apr 8, 2024 · 1 comment
Closed

[Feature]: configure max amount of used memory #316

kitsudaiki opened this issue Apr 8, 2024 · 1 comment
Assignees
@kitsudaiki
Labels
Env: Documentation requires an update of the documentation L: ★☆☆ Expect low difficulty New feature / Improvement new features and improvements of existing features Topic: Usability changes to improve the usability of the program
Milestone
0.5.0

Comments

@kitsudaiki
Copy link
Owner

Feature

Description

At the moment the maximum amount of used memory is hard-coded to 80% of the current free memory. This can result in bad results, if you forget to stop the program and do some other tasks on the same system, which your memory is nearly full...
To prevent this in a dev-envirionment, a config-entry should be added to make it configurable, how much free memory should be used by Hanami for pre-allocation.

Acceptance Criteria

  • new config-entry was added
  • amount of memory for the initial allocation while starting Hanami is configurable

Additional Information

Blocked by

How to test

  • manually testing while setting different config-values for the new entry and check the memory-consumption
@kitsudaiki kitsudaiki added Env: Documentation requires an update of the documentation New feature / Improvement new features and improvements of existing features Topic: Usability changes to improve the usability of the program L: ★☆☆ Expect low difficulty labels Apr 8, 2024
@kitsudaiki kitsudaiki added this to the 0.5.0 milestone Apr 8, 2024
@kitsudaiki kitsudaiki assigned kitsudaiki and unassigned kitsudaiki Apr 8, 2024
kitsudaiki added a commit that referenced this issue Jul 14, 2024
@kitsudaiki
Add (#316): add configuration for memory-consumption
c2ef797 
Added config-entry to define the persentage of max
amound of used free memory. Also added the option
to the example-config, helm-chart and ansible-playbook.
Default is 0.5 or 50%.
kitsudaiki added a commit that referenced this issue Jul 14, 2024
@kitsudaiki
Add (#316): add configuration for memory-consumption
c349606 
Added config-entry to define the percentage of max
amount of used free memory. Also added the option
to the example-config, helm-chart and ansible-playbook.
Default is 0.5 or 50%.
@kitsudaiki kitsudaiki mentioned this issue Jul 14, 2024
Merged
@kitsudaiki kitsudaiki self-assigned this Jul 14, 2024
kitsudaiki added a commit that referenced this issue Jul 14, 2024
@kitsudaiki
Merge pull request #368 from kitsudaiki/feature/make-memory-usage-con…
826ed3d 
…figurable

related issue: #316
@kitsudaiki
Copy link
Owner Author

Added new config-group and -entry:

[processing]
use_of_free_memory = 0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kitsudaiki kitsudaiki

Labels
Env: Documentation requires an update of the documentation L: ★☆☆ Expect low difficulty New feature / Improvement new features and improvements of existing features Topic: Usability changes to improve the usability of the program
Projects
Hanami
Status: Done
Milestone
0.5.0
Development

No branches or pull requests
1 participant
@kitsudaiki