Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA]: use nodiscard #322

Open
kitsudaiki opened this issue May 12, 2024 · 0 comments
Open

[QA]: use nodiscard #322

kitsudaiki opened this issue May 12, 2024 · 0 comments
Labels
L: ★☆☆ Expect low difficulty QA Any tasks, witch improve the quality of the code, documentation and so on Topic: Security security-bugs
Milestone

Comments

@kitsudaiki
Copy link
Owner

QA

Description

With c++17 the [[nodiscard]] was introduced, which can be added to functions, so the compiler gives warnings, when the return-value of the function is not used. This is a quite nice feature to increase security and stability of the code itself, so it should be used where ever it is reasonable.

Acceptance Criteria

  • all functions and methods in the code, with are used for checks or returning true/false to indicate success/fail, now have the [[nodiscard]] in front of it
  • all resulting compiler-warnings are fixed, by adding checks for the return value

Additional Information

Blocked by

How to test

  • compile code and check if there are still no warnings
@kitsudaiki kitsudaiki added QA Any tasks, witch improve the quality of the code, documentation and so on Topic: Security security-bugs L: ★☆☆ Expect low difficulty labels May 12, 2024
@kitsudaiki kitsudaiki added this to the 0.5.0 milestone May 12, 2024
@kitsudaiki kitsudaiki assigned kitsudaiki and unassigned kitsudaiki May 12, 2024
@kitsudaiki kitsudaiki modified the milestones: 0.5.0, 0.5.1 Jun 21, 2024
@kitsudaiki kitsudaiki modified the milestones: 0.5.1, 0.6.0 Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: ★☆☆ Expect low difficulty QA Any tasks, witch improve the quality of the code, documentation and so on Topic: Security security-bugs
Projects
Status: No status
Development

No branches or pull requests

1 participant