Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QA]: add go-linter to CI #343

Open
kitsudaiki opened this issue Jun 25, 2024 · 0 comments
Open

[QA]: add go-linter to CI #343

kitsudaiki opened this issue Jun 25, 2024 · 0 comments
Labels
Env: Infrastructure Issues, which containing infrastructure updates in the webserver, ci-pipeline and so on L: ★★☆ Expect mid difficulty QA Any tasks, witch improve the quality of the code, documentation and so on
Milestone
backlog CI

Comments

@kitsudaiki
Copy link
Owner

kitsudaiki commented Jun 25, 2024 •
edited
Loading

QA

Description

Add a go linter to the CI

Acceptance Criteria

  • go linter was added to the CI
  • all findings of the linter were fixed

Additional Information

At the moment the golangci-lint-linter failes at the protobuf-file with error:

WARN [runner] Can't run linter goanalysis_metalinter: buildir: failed to load package : could not load export data: no export data for "github.com/golang/protobuf/proto" 
...
ERRO Running error: can't run linter goanalysis_metalinter
buildir: failed to load package : could not load export data: no export data for "github.com/golang/protobuf/proto"

Blocked by

How to test
@kitsudaiki kitsudaiki added QA Any tasks, witch improve the quality of the code, documentation and so on L: ★☆☆ Expect low difficulty labels Jun 25, 2024
@kitsudaiki kitsudaiki added this to the backlog CI milestone Jun 25, 2024
@kitsudaiki kitsudaiki added the Env: Infrastructure Issues, which containing infrastructure updates in the webserver, ci-pipeline and so on label Jun 25, 2024
@kitsudaiki kitsudaiki added L: ★★☆ Expect mid difficulty and removed L: ★☆☆ Expect low difficulty labels Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Env: Infrastructure Issues, which containing infrastructure updates in the webserver, ci-pipeline and so on L: ★★☆ Expect mid difficulty QA Any tasks, witch improve the quality of the code, documentation and so on
Projects
Hanami
Status: No status
Milestone
backlog CI
Development

No branches or pull requests
1 participant
@kitsudaiki