Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QA]: secret-detection was added to the CI #344

Closed
kitsudaiki opened this issue Jun 25, 2024 · 0 comments
Closed

[QA]: secret-detection was added to the CI #344

kitsudaiki opened this issue Jun 25, 2024 · 0 comments
Assignees
@kitsudaiki
Labels
Env: Infrastructure Issues, which containing infrastructure updates in the webserver, ci-pipeline and so on L: ★☆☆ Expect low difficulty QA Any tasks, witch improve the quality of the code, documentation and so on
Milestone
0.5.0

Comments

@kitsudaiki
Copy link
Owner

QA

Description

secret-detection was added to the CI

Acceptance Criteria

  • a secret-detection was added to the CI
  • the secret-detection ignores test-code
  • all found secrets outside of the test-code were removed

Additional Information

Blocked by

How to test
@kitsudaiki kitsudaiki added QA Any tasks, witch improve the quality of the code, documentation and so on Env: Infrastructure Issues, which containing infrastructure updates in the webserver, ci-pipeline and so on L: ★☆☆ Expect low difficulty labels Jun 25, 2024
@kitsudaiki kitsudaiki added this to the backlog CI milestone Jun 25, 2024
kitsudaiki added a commit that referenced this issue Jul 28, 2024
@kitsudaiki
ci(#344): add secret-checker
ebc47d1 
Added new secret-checker to the CI to search
for secrets in the code.
kitsudaiki added a commit that referenced this issue Jul 28, 2024
@kitsudaiki
ci(#344): add secret-checker
b96bf1b 
Added new secret-checker to the CI to search
for secrets in the code.
@kitsudaiki kitsudaiki modified the milestones: backlog CI, 0.5.0 Jul 28, 2024
@kitsudaiki kitsudaiki self-assigned this Jul 28, 2024
@kitsudaiki kitsudaiki mentioned this issue Jul 28, 2024
Merged
kitsudaiki added a commit that referenced this issue Jul 28, 2024
@kitsudaiki
Merge pull request #382 from kitsudaiki/qa/add-more-checks-to-ci
3f2d4e2 
related issues:
- #321
- #344
- #379
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kitsudaiki kitsudaiki

Labels
Env: Infrastructure Issues, which containing infrastructure updates in the webserver, ci-pipeline and so on L: ★☆☆ Expect low difficulty QA Any tasks, witch improve the quality of the code, documentation and so on
Projects
Hanami
Status: Done
Milestone
0.5.0
Development

No branches or pull requests
1 participant
@kitsudaiki