Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QA]: rename Bricks #349

Closed
kitsudaiki opened this issue Jun 27, 2024 · 0 comments
Closed

[QA]: rename Bricks #349

kitsudaiki opened this issue Jun 27, 2024 · 0 comments
Assignees
@kitsudaiki
Labels
Breaking: API Changes in the REST-API endpoints Breaking: Templates Change schema of segment- and cluster-templates Env: Documentation requires an update of the documentation Env: Test updates in test-code (functional-tests and so on) L: ★★☆ Expect mid difficulty QA Any tasks, witch improve the quality of the code, documentation and so on Topic: Usability changes to improve the usability of the program
Milestone
0.5.0

Comments

@kitsudaiki
Copy link
Owner

QA

Description

One thing that bothers me for quite a while so far is the naming of the bricks. The were named like this, because they are intended to build a 3D-construction. Later I named other objects "block". This was quite stupid of myself, because now in the code there are brickId and blockId. It is way too similar and can be confusing, when I go quite over the code.

Because of this and because the Bricks are intended to have a virtual hexagon-structure, they should be renamed from "Brick" to "Hexagon". This makes it also in the documentation more clear.

Acceptance Criteria

  • everything in code and documentation was renamed from Brick to Hexagon

Additional Information

Blocked by

How to test
@kitsudaiki kitsudaiki added Breaking: API Changes in the REST-API endpoints QA Any tasks, witch improve the quality of the code, documentation and so on Env: Documentation requires an update of the documentation Env: Test updates in test-code (functional-tests and so on) Topic: Usability changes to improve the usability of the program Breaking: Templates Change schema of segment- and cluster-templates L: ★★☆ Expect mid difficulty labels Jun 27, 2024
@kitsudaiki kitsudaiki added this to the 0.5.0 milestone Jun 27, 2024
@kitsudaiki kitsudaiki self-assigned this Jun 27, 2024
kitsudaiki added a commit that referenced this issue Jul 14, 2024
@kitsudaiki
Change (#349): rename bricks
04376e7 
Renamed bricks to hexagons to avoid conflics
with the similar named blocks.
@kitsudaiki kitsudaiki mentioned this issue Jul 14, 2024
Merged
kitsudaiki added a commit that referenced this issue Jul 14, 2024
@kitsudaiki
Merge pull request #365 from kitsudaiki/qa/rename-bricks
5ce712f 
related issue: #349
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kitsudaiki kitsudaiki

Labels
Breaking: API Changes in the REST-API endpoints Breaking: Templates Change schema of segment- and cluster-templates Env: Documentation requires an update of the documentation Env: Test updates in test-code (functional-tests and so on) L: ★★☆ Expect mid difficulty QA Any tasks, witch improve the quality of the code, documentation and so on Topic: Usability changes to improve the usability of the program
Projects
Hanami
Status: Done
Milestone
0.5.0
Development

No branches or pull requests
1 participant
@kitsudaiki