Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support client certificates when communicating with REQ_URL #334

Open
wasim-nihal opened this issue Mar 18, 2024 · 4 comments
Open

support client certificates when communicating with REQ_URL #334

wasim-nihal opened this issue Mar 18, 2024 · 4 comments

Comments

@wasim-nihal
Copy link
Contributor

Presently, there is no provision to configure the client certificates in kiwigrid k8s sidecar when making a request to REQ_URL. But there are some cases where the server is required to validate the client (mTLS) which is the case in our organization.

So, it is better to add a support to configure the client certificate and client key by introducing two new environment variables namely REQ_CLIENT_CERT and REQ_CLIENT_KEY respectively that take the path to the corresponding files.

If the community feels that this feature would be help, I would like to open a PR for the same.

wasim-nihal added a commit to nokia/kiwigrid-k8s-sidecar that referenced this issue Mar 18, 2024
Signed-off-by: Syed Nihal <syed.nihal@nokia.com>
Copy link

This issue has been automatically marked as stale because it has not had any activity in the last 60 days. Thank you for your contributions.

@github-actions github-actions bot added the stale close issues and PRs after 60 days of inactivity label Sep 28, 2024
wasim-nihal added a commit to nokia/kiwigrid-k8s-sidecar that referenced this issue Sep 30, 2024
Signed-off-by: wasim-nihal <sswasim64@gmail.com>
@wasim-nihal
Copy link
Contributor Author

Commenting to remove the stale label, as the PR #335 is currently under review.

@github-actions github-actions bot removed the stale close issues and PRs after 60 days of inactivity label Oct 1, 2024
Copy link

github-actions bot commented Dec 1, 2024

This issue has been automatically marked as stale because it has not had any activity in the last 60 days. Thank you for your contributions.

@github-actions github-actions bot added the stale close issues and PRs after 60 days of inactivity label Dec 1, 2024
@wasim-nihal
Copy link
Contributor Author

Commenting to remove stale marker

@github-actions github-actions bot removed the stale close issues and PRs after 60 days of inactivity label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant