Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using .url functionality with large files can result in OOMKill #336

Open
cryptk opened this issue Mar 19, 2024 · 1 comment
Open

Using .url functionality with large files can result in OOMKill #336

cryptk opened this issue Mar 19, 2024 · 1 comment
Labels
stale close issues and PRs after 60 days of inactivity

Comments

@cryptk
Copy link

cryptk commented Mar 19, 2024

Using the k8s-sidecar .url functionality to download files from a URL, if those files are quite large (in this case they are model files from HugingFace.co for AI systems) it is quite possible for the container to run out of memory. There should be an option to download the files directly to disk rather than buffering the downloads in memory. You could do this with a .partial suffix on the filename while the file is being downloaded and then have a rename at the end when the file download is complete in order to prevent issues if the sidecar were interrupted mid-download.

Copy link

This issue has been automatically marked as stale because it has not had any activity in the last 60 days. Thank you for your contributions.

@github-actions github-actions bot added the stale close issues and PRs after 60 days of inactivity label Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale close issues and PRs after 60 days of inactivity
Projects
None yet
Development

No branches or pull requests

1 participant